Skip to content

feat(workspaces): add option to disable focus hint icons - #4021

Open
zebubull wants to merge 1 commit into
noctalia-dev:mainfrom
zebubull:workspace-icon-toggle
Open

feat(workspaces): add option to disable focus hint icons#4021
zebubull wants to merge 1 commit into
noctalia-dev:mainfrom
zebubull:workspace-icon-toggle

Conversation

@zebubull

Copy link
Copy Markdown

Summary

Added a "Show Icons" toggle to the workspaces widget to control whether icons are drawn in focus hint mode.

Motivation

I prefer the way inactive workspaces pills are drawn in the focus hint style but don't want the focused app icon to be shown in the active pill. I tried using the regular style and lowering the inactive pill size, but this only affects the width of the inactive pills and leaves them full height. I figured the best way to solve this would be to add a "show icons" setting, similar to the existing "show labels" setting, to allow for the focus hint style pills without showing app icons.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Testing

I made sure both the gui setting and the "show_icons" toml key toggled the app icon, and that the gui setting was only visible when in focus hint mode. I also made sure that icons are shown by default to be consistent with existing behavior.

Manual Coverage

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors

Screenshots / Videos

2026-08-19.15-25-57.mp4

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format with clang-format v22+ installed, or this PR has no code changes.
  • I ran the relevant build or test commands, or explained why they were not run.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I will update end-user documentation after merge, or this PR does not change user-facing configuration or behavior.
  • I added or updated assets/translations/en.json, or this PR adds no new user-facing strings.
  • I did not edit non-English translation files unless this PR is explicitly for translation tooling, an import/export sync, or a maintainer-requested locale change.
  • I used the existing canonical names for config keys, IPC names, paths, and identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant